Repository navigation
schannel: clear borrowed sslContext on close - #22720
Closed
martin-fzi wants to merge 1 commit into
Closed
martin-fzi wants to merge 1 commit into
martin-fzi wants to merge 1 commit into
Conversation
vszakats
reviewed
Aug 28, 2026
There was a problem hiding this comment.
Pull request overview
Clears Schannel’s borrowed connection-level security context before freeing its backing handle.
Changes:
- Nulls
sslContextonly when it references the context being destroyed. - Preserves compatibility with older Windows SDKs.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
I opened #22725 which enables Perhaps it's best to merge that first, then rebase this PR to make |
vszakats
reviewed
Aug 28, 2026
vszakats
approved these changes
Sep 4, 2026
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Negotiate and NTLM consumers were traced, and no reachable post-free dereference was found.
The pointer is still left dangling after Schannel teardown, so clear it when the context is destroyed.