schannel: clear PFX password before free - #22721
Closed
martin-fzi wants to merge 1 commit into
Closed
martin-fzi wants to merge 1 commit into
martin-fzi wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Clears the temporary UTF-16 PFX password before releasing its memory.
Changes:
- Zeroes the full password buffer before freeing it.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bagder
approved these changes
Aug 28, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The temporary UTF-16 password used for PFX import was freed without being cleared.
Zero the buffer before freeing it to reduce the lifetime of sensitive credential data.