Conversation
vszakats
marked this pull request as draft
August 28, 2026 15:05
vszakats
changed the title
```
D:/a/curl/curl/lib/vauth/spnego_sspi.c:96:3: error: unknown type name 'SecPkgContext_Bindings'; did you mean 'SecPkgContext_Flags'?
SecPkgContext_Bindings pkgBindings = { 0, NULL };
^~~~~~~~~~~~~~~~~~~~~~
SecPkgContext_Flags
D:/a/curl/curl/lib/vauth/spnego_sspi.c:96:45: error: excess elements in scalar initializer
SecPkgContext_Bindings pkgBindings = { 0, NULL };
^~~~
D:/a/curl/curl/lib/vauth/spnego_sspi.c:96:45: note: (near initialization for 'pkgBindings')
D:/a/curl/curl/lib/vauth/spnego_sspi.c:238:44: error: request for member 'BindingsLength' in something not a structure or union
binding_buf->cbBuffer = pkgBindings.BindingsLength;
^
D:/a/curl/curl/lib/vauth/spnego_sspi.c:239:44: error: request for member 'Bindings' in something not a structure or union
binding_buf->pvBuffer = pkgBindings.Bindings;
^
D:/a/curl/curl/lib/vauth/spnego_sspi.c:268:17: error: request for member 'Bindings' in something not a structure or union
if(pkgBindings.Bindings)
^
D:/a/curl/curl/lib/vauth/spnego_sspi.c:269:47: error: request for member 'Bindings' in something not a structure or union
Curl_pSecFn->FreeContextBuffer(pkgBindings.Bindings);
^
```
https://github.com/curl/curl/actions/runs/33183414391/job/98890201288?pr=22725
vszakats
changed the title
SECPKG_ATTR_ENDPOINT_BINDINGS for mingw-w64 <9
vszakats
marked this pull request as ready for review
August 28, 2026 15:28
There was a problem hiding this comment.
Pull request overview
Enables SSPI channel binding with pre-v9 mingw-w64 headers by supplying missing compatibility definitions and removing obsolete guards.
Changes:
- Adds fallback endpoint-binding SSPI declarations.
- Enables Schannel context propagation for NTLM and SPNEGO across all Windows SSPI builds.
- Reuses existing channel-binding query and cleanup paths.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
lib/curl_sspi.h |
Adds compatibility definitions for older headers. |
lib/vtls/schannel.c |
Always exposes the Schannel context to SSPI. |
lib/vauth/vauth.h |
Makes authentication context fields universally available with SSPI. |
lib/vauth/spnego_sspi.c |
Enables SPNEGO endpoint bindings. |
lib/vauth/ntlm_sspi.c |
Enables NTLM endpoint bindings. |
lib/urldata.h |
Stores the SSL context for every Windows SSPI build. |
lib/http_ntlm.c |
Propagates the SSL context into NTLM state. |
lib/http_negotiate.c |
Propagates the SSL context into Negotiate state. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
vszakats
changed the title
SECPKG_ATTR_ENDPOINT_BINDINGS for mingw-w64 <9
jay
reviewed
Aug 28, 2026
jay
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop
SECPKG_ATTR_ENDPOINT_BINDINGSguards and declare the missingmacro and struct for mingw-w64 <9. To bring these builds on par with the
rest of supported Windows toolchains.
Follow-up to 0966233 #3321