Conversation
Added test 2318 to verify. Reported-by: Stanislav Fort (Aisle Research)
Because of the localhost treatement
There was a problem hiding this comment.
Pull request overview
Updates PSL cookie handling so cookies set for an exact public-suffix host become host-only.
Changes:
- Converts exact PSL-domain cookies from tail-matching to host-only.
- Adds regression coverage and updates affected expectations.
- Registers test 2318.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
lib/cookie.c |
Implements host-only conversion. |
tests/data/test2318 |
Adds regression coverage. |
tests/data/test798 |
Updates localhost expectation. |
tests/data/test1136 |
Updates AWS PSL expectation. |
tests/data/Makefile.am |
Registers the new test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jcamiel
added a commit
to Orange-OpenSource/hurl
that referenced
this pull request
Sep 3, 2026
…22730> curl 8.22 changes cookie managment for PSL. A cookie that set Domain=localhost for request on localhost becomes host only. So in curl 8.22, such a request changes a cookie from subdomain to host only.
jcamiel
added a commit
to Orange-OpenSource/hurl
that referenced
this pull request
Sep 3, 2026
…22730> curl 8.22 changes cookie managment for PSL. A cookie that set Domain=localhost for request on localhost becomes host only. So in curl 8.22, such a request changes a cookie from subdomain to host only.
jcamiel
added a commit
to Orange-OpenSource/hurl
that referenced
this pull request
Sep 3, 2026
…22730> curl 8.22 changes cookie managment for PSL. A cookie that set Domain=localhost for request on localhost becomes host only. So in curl 8.22, such a request changes a cookie from subdomain to host only.
jcamiel
added a commit
to Orange-OpenSource/hurl
that referenced
this pull request
Sep 3, 2026
…22730> curl 8.22 changes cookie managment for PSL. A cookie that set Domain=localhost for request on localhost becomes host only. So in curl 8.22, such a request changes a cookie from subdomain to host only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test 2318 to verify.
Reported-by: Stanislav Fort (Aisle Research)