Conversation
vszakats
added
authentication
Windows
Also drop redundant cast and comment.
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
Centralizes SSPI identity flag selection for ANSI and Unicode Windows builds.
Changes:
- Adds a local SSPI identity flag macro.
- Replaces duplicated conditional assignments and removes a redundant cast/comment.
File summaries
| File | Description |
|---|---|
lib/curl_sspi.h |
Defines the build-specific identity flag macro. |
lib/curl_sspi.c |
Uses the macro when creating identities. |
lib/vauth/spnego_sspi.c |
Uses the macro for SPNEGO identities. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also drop redundant cast and comment.