New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have linker generate proper PDB for windows build #2274

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@amarcionek
Contributor

amarcionek commented Jan 29, 2018

Link.exe requires /DEBUG to properly generate a full pdb file on release
builds.

Have linker generate proper PDB for windows build
Link.exe requires /DEBUG to properly generate a full pdb file on release
builds.
@amarcionek

This comment has been minimized.

Show comment
Hide comment
@amarcionek

amarcionek Jan 29, 2018

Contributor

FYI: Here is the relevant Microsoft document on the subject. Without /DEBUG, a PBD file is built for libcurl.dll but Visual Studio complains there are no symbols for it when debugging and I can see its only a few 10s of KBs in size, not a few MBs.

Contributor

amarcionek commented Jan 29, 2018

FYI: Here is the relevant Microsoft document on the subject. Without /DEBUG, a PBD file is built for libcurl.dll but Visual Studio complains there are no symbols for it when debugging and I can see its only a few 10s of KBs in size, not a few MBs.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Jan 30, 2018

Member

Thanks!

Member

bagder commented Jan 30, 2018

Thanks!

@bagder bagder closed this in a406e86 Jan 30, 2018

@rodwiddowson

This comment has been minimized.

Show comment
Hide comment
@rodwiddowson

rodwiddowson Jan 30, 2018

Contributor

Note that this fixes only one of the three different build mechanisms......

Contributor

rodwiddowson commented Jan 30, 2018

Note that this fixes only one of the three different build mechanisms......

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Jan 30, 2018

Member

So the same issue exists on the others? Even if it does, accepting a fix that corrects a problem still seems the right thing to do even if there are other places with problems around...

Member

bagder commented Jan 30, 2018

So the same issue exists on the others? Even if it does, accepting a fix that corrects a problem still seems the right thing to do even if there are other places with problems around...

@amarcionek

This comment has been minimized.

Show comment
Hide comment
@amarcionek

amarcionek Jan 30, 2018

Contributor

Are the two others the projects folder and cmake? I can look into them over the course of the week.

Contributor

amarcionek commented Jan 30, 2018

Are the two others the projects folder and cmake? I can look into them over the course of the week.

@rodwiddowson

This comment has been minimized.

Show comment
Hide comment
@rodwiddowson

rodwiddowson Jan 30, 2018

Contributor

thanks @amarcionek I don't speak Cmake well enough to look (plus my life is a bit busy). Very much appreciated on behalf of this windows user

Contributor

rodwiddowson commented Jan 30, 2018

thanks @amarcionek I don't speak Cmake well enough to look (plus my life is a bit busy). Very much appreciated on behalf of this windows user

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.