Conversation
Detected by llvm/clang 23.1.0:
```
lib/easy.c:83:13: warning: variable 'easy_init_flags' set but not used [clang-diagnostic-unused-but-set-global]
83 | static long easy_init_flags;
| ^
lib/easy.c:83:13: warning: variable 'easy_init_flags' set but not used [-Wunused-but-set-global]
83 | static long easy_init_flags;
| ^
```
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
Scopes Windows-only initialization state to Windows builds, eliminating Clang’s unused-global warning elsewhere.
Changes:
- Guards
easy_init_flagsusage with_WIN32. - Explicitly marks
flagsunused on non-Windows platforms. - Resets Windows flags during Windows cleanup.
File summaries
| File | Description |
|---|---|
lib/easy.c |
Makes initialization-flag storage Windows-specific. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detected by llvm/clang 23.1.0: