Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
This PR updates the in-tree wcurl wrapper script to upstream version 2026.08.30, bringing in new safety checks and URL/option handling improvements, plus a small documentation reflow.
Changes:
- Harden shell/script behavior: disable glob expansion, tighten URL splitting via IFS handling, and expand unsafe percent-decode list (adds
%7F). - Improve curl invocation safety and behavior: use
--url, handle--curl-options/--outputmissing-argument errors, and error out on multi-URL--outputwhen curl is too old for--no-clobber. - Minor docs formatting adjustment.
File summaries
| File | Description |
|---|---|
| scripts/wcurl | Imports upstream updates: stricter shell flags, safer option/URL handling, filename parsing tweak, and a curl version guard for multi-URL --output. |
| docs/wcurl.md | Reflows a paragraph for readability (no behavioral change). |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/curl/wcurl/releases/tag/v2026.08.30