conncache: guess maxconnects different

[icing]

Take the number of attached transfers instead of the running ones as guidance how many connections the multi should cache.

In addition, when guessing, only evict a connection if it has not been in use for a second or longer.

[Copilot]

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates automatic connection-cache sizing to use attached transfers and delay eviction of recently used connections.

Changes:

• Sizes the inferred cache at twice the attached-transfer count.
• Requires guessed-cache eviction candidates to be idle for one second.
• Passes consistent timestamps through connection-limit checks.

File summaries

File	Description
lib/url.c	Supplies connection creation time to limit checks.
lib/multiif.h	Declares attached-transfer counting API.
lib/multi.c	Implements transfer counting and type updates.
lib/conncache.h	Extends the limit-check interface.
lib/conncache.c	Revises inferred sizing and age-aware eviction.

Review details

Suppressed comments (1)

lib/conncache.c:659

• The new comment is missing the subject “it” and ends the sentence with a comma.

    /* We are guessing. So, only evict a "seemingly superfluous" connection
     * when has not been used for this long, */

• Files reviewed: 5/5 changed files
• Comments generated: 2
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.