Skip to content

CURLOPT_USERNAME.md: ambient username caveats - #22768

Closed
bagder wants to merge 4 commits into
masterfrom
bagder/username-ambient
Closed

bagder wants to merge 4 commits into
masterfrom
bagder/username-ambient

Conversation

@bagder

@bagder bagder commented Aug 31, 2026

Copy link
Copy Markdown
Member

No description provided.

@bagder
bagder requested a balanced review from Copilot August 31, 2026 20:28
@bagder
bagder marked this pull request as ready for review August 31, 2026 20:28
@bagder
bagder requested a review from vszakats August 31, 2026 20:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Documents caveats when libcurl uses ambient credentials.

Changes:

  • Explains ambient-user behavior for Negotiate and SSPI-backed NTLM.
  • Corrects the default username value to NULL.
File summaries
File Description
docs/libcurl/opts/CURLOPT_USERNAME.md Adds ambient credential guidance and updates the default.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/libcurl/opts/CURLOPT_USERNAME.md Outdated
bagder and others added 2 commits August 31, 2026 22:38
more words

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@bagder bagder closed this in c23bc84 Aug 31, 2026
@bagder
bagder deleted the bagder/username-ambient branch August 31, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants