tidy-up: formatting, messages and comments

[vszakats]

• config-*.h: 'handcrafted'
• tool_operate: rename CURL * variable to curl to match rest
  of code.
• urldata.h: drop redundant parentheses from macro values.
• curlinfo, dnsd: omit unused main arguments.
• easy: sync function name in error message with source code.
• cmake: drop period from version requirement messages.
• tests/server/util: link three signal-related articles.
• inline comments, fix indent, newlines, clang-format.

[Copilot]

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Tidies formatting, comments, diagnostics, and naming across curl without intended behavioral changes.

Changes:

• Normalizes C formatting and comments.
• Clarifies diagnostics and configuration messages.
• Removes unused parameters and renames a local handle.

File summaries

File	Description
.clang-tidy.yml	Clarifies a lint comment.
CMake/PickyWarnings.cmake	Shortens warning documentation.
CMakeLists.txt	Normalizes version messages.
lib/api.h	Adds API section labels.
lib/cf-socket.c	Tidies conditional formatting.
lib/config-mac.h	Corrects “handcrafted.”
lib/config-os400.h	Corrects “handcrafted.”
lib/cookie.c	Removes an extra blank line.
lib/easy.c	Corrects a function name in diagnostics.
lib/protocol.c	Removes an extra blank line.
lib/uint-hashset.c	Removes an extra blank line.
lib/urldata.h	Simplifies macro formatting.
lib/vdns/asyn-base.c	Spaces bitwise expressions.
lib/vdns/cf-dns.c	Reformats DNS code.
lib/vdns/dnscache.c	Reformats DNS-cache code.
lib/vdns/dnscache.h	Aligns declarations.
lib/vdns/hostip.c	Spaces bitwise expressions.
lib/vquic/cf-ngtcp2-cmn.c	Removes an extra blank line.
lib/vquic/vquic.c	Aligns a preprocessor condition.
src/config2setopts.c	Capitalizes hash names.
src/curlinfo.c	Removes unused main parameters.
src/tool_operate.c	Renames and reformats local code.
tests/server/dnsd.c	Changes the unsupported Amiga stub signature.
tests/server/util.c	Tidies and expands signal comments.

Review details

• Files reviewed: 18/24 changed files
• Comments generated: 2
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

lib/urldata.h:1232

• Forwarding s without parentheses makes this macro unsafe when s is another macro that expands to a comma expression: the expanded comma becomes another function argument. Preserve the wrapper's existing argument grouping.

  Curl_u8_strset_setn(&(d)->set.strings, (uint8_t)(id), s)

• Files reviewed: 17/24 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

🟢 Approval recommended

Review details

• Files reviewed: 16/24 changed files
• Comments generated: 0 new
• Review effort level: Balanced