Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
Optimizes URL escaping by batching consecutive unreserved characters, improving percent-encoding performance.
Changes:
- Tracks contiguous unreserved input spans.
- Appends spans in bulk while encoding reserved bytes individually.
File summaries
| File | Description |
|---|---|
lib/escape.c |
Batches dynamic-buffer appends during URL escaping. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bagder
force-pushed
the
bagder/escape-more
branch
from
September 2, 2026 06:52
a2f699f to
cc9e11e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bagder
force-pushed
the
bagder/escape-more
branch
from
September 2, 2026 22:03
cc9e11e to
47731c3
Compare
bagder
changed the title
Primarily thanks to a new loopup table and taking bigger chunks to work on instead of byte-by-byte, this PR does decoding twice as fast as before and it encodes five times faster (on my x86-64). Closes #22780
bagder
force-pushed
the
bagder/escape-more
branch
from
September 3, 2026 08:06
d1d9df2 to
fc10333
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(fastest of three runs)
branch: master
URL encode
Time/loop: 2082.52 ns
URL decode (fastest of three runs)
Time/loop: 612.65 ns
branch: this PR
URL encode
Time/loop: 388.95 ns (-81%)
URL decode
Time/loop: 328.88 ns (-46%)