Repository navigation
Conversation
Previously it gave up after 100. Some users use this feature when downloading large number of files in a glob range and then 100 is on the small side.
There was a problem hiding this comment.
🟡 Changes recommended
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Expands --no-clobber filename suffix attempts beyond the previous limit.
Changes:
- Raises the suffix limit to 9999.
- Updates option documentation accordingly.
File summaries
| File | Description |
|---|---|
src/tool_cb_wrt.c |
Expands numbered filename retries. |
docs/cmdline-opts/no-clobber.md |
Documents the new limit. |
Review details
Suppressed comments (1)
src/tool_cb_wrt.c:73
- The strict comparison makes the documented final suffix unreachable:
next_numstarts at 1 and is formatted before incrementing, so the last attempted name is.9998. Use an inclusive bound so.9999is actually tried as promised by the option documentation and PR title.
(next_num < MAX_CLOBBER_ATTEMPTS)) {
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it gave up after 100.
Some users use this feature when downloading large number of files in a glob range and then 100 is on the small side.