Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new extension detection currently scans the full path (not just the basename), which can generate incorrect output paths when directories contain dots or when the basename begins with a dot.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates curl’s --no-clobber filename generation so that when the requested output name has an extension, the numeric suffix is injected before the extension (e.g., image-1.jpg), and documents the new behavior.
Changes:
- Refactors output filename retry logic into a helper that inserts
-Nbefore the extension. - Updates
--no-clobberoption documentation to describe the extension-aware naming scheme.
File summaries
| File | Description |
|---|---|
| src/tool_cb_wrt.c | Adds clobber_name() and switches retry naming to insert the number before the extension. |
| docs/cmdline-opts/no-clobber.md | Documents the new extension-aware --no-clobber filename behavior. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Starting in curl 8.23.0, if the target file name uses an extension, curl instead creates the new file name by inserting `-[num]` before the extenstion. Downloading to `image.jpg` with --no-clobber, curl first tries to save it as `image-1.jpg` then `image-2.jpg` etc. Closes #22787
bagder
force-pushed
the
bagder/no-clobber-name
branch
from
September 3, 2026 07:02
856c855 to
9d9bc1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting in curl 8.23.0, if the target file name uses an extension, curl instead creates the new file name by inserting
-[num]before the extenstion. Downloading toimage.jpgwith --no-clobber, curl first tries to save it asimage-1.jpgthenimage-2.jpgetc.