Skip to content

Fix preprocessor check for old Darwin versions - #22797

Closed
Un1q32 wants to merge 4 commits into
curl:masterfrom
Un1q32:master
Closed

Un1q32 wants to merge 4 commits into
curl:masterfrom
Un1q32:master

Conversation

@Un1q32

@Un1q32 Un1q32 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Older versions of Darwin (macOS, iOS, tvOS, etc) before macOS 10.13 don't have IP_RECVTOS, but they still get this code because they do have IP_TOS. This makes the preprocessor check for this code more thorough to allow curl to compile on older Darwin versions again.

@github-actions github-actions Bot added the HTTP/3 h3 or quic related label Sep 2, 2026
@vszakats vszakats added build appleOS specific to an Apple operating system labels Sep 2, 2026
Comment thread lib/vquic/vquic.c Outdated
@vszakats

vszakats commented Sep 2, 2026 •

Copy link
Copy Markdown
Member

Can you say how to reproduce such build? We build for older macOS versions in CI,
yet not catching this issue.

@Un1q32

Un1q32 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Can you say how to reproduce such build? We build for older macOS versions in CI, yet not catching this issue.

You would need an old SDK, building for an old version with a newer SDK wouldn't have the issue.

Un1q32 and others added 2 commits September 2, 2026 06:04
Co-authored-by: Viktor Szakats <vszakats@users.noreply.github.com>
@bagder bagder closed this in 5dbdaca Sep 2, 2026
@bagder

bagder commented Sep 2, 2026

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appleOS specific to an Apple operating system build HTTP/3 h3 or quic related

Development

Successfully merging this pull request may close these issues.

3 participants