Repository navigation
Conversation
bagder
approved these changes
Sep 3, 2026
There was a problem hiding this comment.
🟡 Changes recommended
It changes documented stream-limit behavior and introduces an allocation-size overflow path.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Refactors multi-handle storage to reduce its footprint and use fixed-width limit types.
Changes:
- Co-locates transfer-buffer metadata and data in single allocations.
- Converts connection limits and timeout fields to narrower or appropriate types.
- Safely caps HTTP/3 concurrency when converting to
int.
File summaries
| File | Description |
|---|---|
lib/vquic/cf-ngtcp2.c |
Caps stream concurrency at INT_MAX. |
lib/url.c |
Updates connection-limit formatting. |
lib/multiif.h |
Changes concurrency accessor type. |
lib/multihandle.h |
Shrinks and reorganizes multi-handle fields. |
lib/multi.c |
Updates option handling and buffer allocation. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
icing
force-pushed
the
multi-easy-shrinks
branch
from
September 3, 2026 07:57
ddad25d to
cebe440
Compare
- new `struct Curl_fixed_buf` keeping data and length in one alloc for upload/download/socket buffers held in the multi - max_host_connections changed to uint32_t - max_total_connections changed to uint32_t - maxconnects changed to uint32_t - last_timeout_ms changed to timediff_t - now_access_count removed, no one used it
- CURLMOPT_MAX_CONCURRENT_STREAMS: set to 100 for values > INT_MAX, just as before - add function to allocate `struct Curl_fixed_buf`, checking overflow an very large buffer requests.
icing
force-pushed
the
multi-easy-shrinks
branch
from
September 3, 2026 08:04
cebe440 to
02ecd75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
struct Curl_fixed_bufkeeping data and length in one alloc for upload/download/socket buffers held in the multi