Repository navigation
Conversation
cmeister2
added a commit
that referenced
this pull request
Sep 2, 2026
Use byte-sized multi API call-stack fields, remove the unused uint32 table destructor, narrow shared buffer lengths to uint32_t and replace the last timeout value with a bit. This reduces Curl_multi by 40 bytes on 64-bit builds. Closes #22807
cmeister2
force-pushed
the
cm2/multi-small-cleanups
branch
from
September 2, 2026 17:25
2bb1c35 to
9f5f723
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The field narrowing is guarded against overflow and the affected behavior has focused unit coverage.
Pull request overview
Reduces Curl_multi memory usage while preserving timer, buffer, API-stack, and table behavior.
Changes:
- Narrows API-stack and shared-buffer fields.
- Simplifies timer state and uint32 table initialization.
- Adds timer and oversized-buffer unit coverage.
File summaries
| File | Description |
|---|---|
lib/api.c |
Adds byte-width safety checks and conversions. |
lib/api.h |
Narrows multi API stack fields. |
lib/multi.c |
Simplifies timer state and validates buffer size. |
lib/multihandle.h |
Shrinks fields in Curl_multi. |
lib/multiif.h |
Corrects buffer API documentation. |
lib/uint-table.c |
Removes unused destructor handling. |
lib/uint-table.h |
Simplifies the table API and structure. |
docs/internals/UINT_SETS.md |
Updates table memory documentation. |
tests/unit/unit3212.c |
Adapts to the simplified table API. |
tests/unit/unit3230.c |
Tests timer transitions and buffer limits. |
tests/unit/Makefile.inc |
Registers the new unit source. |
tests/data/test3230 |
Defines the new unit test case. |
tests/data/Makefile.am |
Registers test 3230. |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Use byte-sized multi API call-stack fields, remove the unused uint32 table destructor and replace the last timeout value with a bit. This reduces Curl_multi by 32 bytes on 64-bit builds. Closes #22807
cmeister2
force-pushed
the
cm2/multi-small-cleanups
branch
from
September 3, 2026 11:53
9f5f723 to
b6a93f0
Compare
icing
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use byte-sized multi API call-stack fields, remove the unused uint32
table destructor and replace the last timeout value with a bit.
This reduces Curl_multi by 32 bytes on 64-bit builds.