Repository navigation
Conversation
Reported-by: Stanislav Fort
There was a problem hiding this comment.
🟡 Changes recommended
The newly added sentences are ambiguous/potentially inaccurate about the nature of the issuer check and can mislead readers about whether the provided issuer cert is validated/trusted versus only used for an issuer-check operation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates libcurl option documentation for the ISSUERCERT and PROXY_ISSUERCERT options (and their *_BLOB variants) to clarify what kind of issuer checking is performed.
Changes:
- Adds a note describing how the provided issuer certificate is checked in relation to the peer/proxy certificate.
- Reflows a few paragraphs for consistency/readability across the option pages.
File summaries
| File | Description |
|---|---|
| docs/libcurl/opts/CURLOPT_PROXY_ISSUERCERT.md | Adds clarifying text about proxy issuer certificate checking semantics. |
| docs/libcurl/opts/CURLOPT_PROXY_ISSUERCERT_BLOB.md | Same clarification as above for the blob-based proxy option, plus minor reflow. |
| docs/libcurl/opts/CURLOPT_ISSUERCERT.md | Adds clarifying text about issuer certificate checking semantics. |
| docs/libcurl/opts/CURLOPT_ISSUERCERT_BLOB.md | Same clarification as above for the blob-based option, plus minor reflow. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wording Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported-by: Stanislav Fort