Repository navigation
Conversation
Check that current peer is *equal* from last peer's state information. This accomodates also scheme changes, which the previous check did not.
bagder
approved these changes
Sep 4, 2026
There was a problem hiding this comment.
🟡 Changes recommended
A regression test for scheme-only changes is required before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates Digest authentication state invalidation to account for URL scheme changes.
Changes:
- Uses full peer equality, including scheme, before reusing Digest state.
- Requires a regression test covering scheme-only peer changes.
File summaries
| File | Description |
|---|---|
lib/http_digest.c |
Resets Digest state when peer details, including scheme, change. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that current peer is equal from last peer's state information. This accomodates also scheme changes, which the previous check did not.