config2setopts: always set the security options for SCP/SFTP

[bagder]

No description provided.

[Copilot]

🟡 Changes recommended

ssh_setopts() gating and known-hosts fallback path handling currently introduce incorrect/non-portable behavior and cause SSH options to be emitted for non-SSH transfers.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates curl’s config2setopts SSH option handling to ensure SCP/SFTP security-related options (notably known-hosts handling) are always configured, and adjusts an existing --libcurl test fixture to tolerate newly emitted SSH options.

Changes:

• Modified ssh_setopts() invocation/signature and its known-hosts fallback behavior in src/config2setopts.c.
• Updated tests/data/test1679 to strip CURLOPT_SSH_KNOWNHOSTS from generated --libcurl output.

File summaries

File	Description
src/config2setopts.c	Alters when/how SSH-related libcurl options (known-hosts and hostkey settings) are applied during option setup.
tests/data/test1679	Updates --libcurl output normalization by stripping CURLOPT_SSH_KNOWNHOSTS.

Review details

Suppressed comments (1)

src/config2setopts.c:1046

• protocol_setopts() was updated to call ssh_setopts(config, curl) without passing use_proto. If ssh_setopts is gated on use_proto (as it should be), this call site needs to pass it through so SSH options are only set for SCP/SFTP transfers.

  result = ssh_setopts(config, curl);
  if(setopt_bad(result))

• Files reviewed: 2/2 changed files
• Comments generated: 3
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.