Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The behavioral change is small and low-risk, with only a minor documentation/comment clarity issue noted.
Pull request overview
Adjusts cookie file loading behavior so a single malformed/unacceptable cookie line does not stop processing the remainder of the cookie file, aligning cookie loading with the “best-effort” approach used elsewhere in the cookie parser.
Changes:
- Treat non-OOM failures from
Curl_cookie_add()duringcookie_load()as non-fatal by clearingresulttoCURLE_OKand continuing to read subsequent lines.
File summaries
| File | Description |
|---|---|
| lib/cookie.c | Continue cookie-file parsing after per-line cookie add failures, only stopping on out-of-memory. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.