Repository navigation
Conversation
Remove the members `multi *` and `initialized`, passing multi or admin handles as parameters. When adding, pass a "max_keep" number to cshutdown for limiting growth. conncache calculates that based on multi settings and current pool size.
There was a problem hiding this comment.
🟡 Changes recommended
The new unlimited-pool shutdown cap lacks regression coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Refactors connection shutdown management to reduce cshutdn state and bound pending shutdown growth.
Changes:
- Pass multi/admin handles explicitly.
- Remove redundant initialization state.
- Calculate shutdown limits from pool configuration and size.
File summaries
| File | Description |
|---|---|
lib/multi.c |
Initializes shutdown state and passes admin handles. |
lib/cshutdn.h |
Updates shutdown structure and APIs. |
lib/cshutdn.c |
Implements stateless handle passing and shutdown limits. |
lib/conncache.c |
Calculates and applies pending-shutdown caps. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+232
to
+234
| else /* no connection limit set, let's restrict growth nevertheless */ | ||
| max_shutdowns = CURLMAX(cpool->num_conn / 4, 128); | ||
| Curl_cshutdn_add(&multi->cshutdn, multi, conn, max_shutdowns); |
bagder
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the members
multi *andinitialized, passing multi or admin handles as parameters.When adding, pass a "max_keep" number to cshutdown for limiting growth. conncache calculates that based on multi settings and current pool size.