Repository navigation
Conversation
Added test3109: verify HSTS when parent+subdomain expires before child Reported-by: Stanislav Fort
There was a problem hiding this comment.
🟢 Approval recommended
The functional change is focused and covered by a regression test; only a minor comment typo remains.
Pull request overview
Fixes HSTS cache loading so parent-domain policies do not suppress child entries.
Changes:
- Limits duplicate detection to exact hostnames.
- Adds and registers a regression test.
File summaries
| File | Description |
|---|---|
lib/hsts.c |
Uses exact matching during HSTS loading. |
tests/data/test3109 |
Tests preserving a longer-lived child entry. |
tests/data/Makefile.am |
Registers the regression test. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
language Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test3109: verify HSTS when parent+subdomain expires before child
Reported-by: Stanislav Fort