Repository navigation
Conversation
We stored the "destination" string at each connection bundle, but it was never necessary to have it for operations. Remove the duplicated string from the bundle.
There was a problem hiding this comment.
🟢 Approval recommended
Hash keys are copied internally, and destination-based bundle operations remain correct.
Pull request overview
Removes the redundant destination copy from connection-pool bundles while retaining destination-based hash lookup.
Changes:
- Simplifies bundle allocation.
- Uses connection destination strings for bundle lookup, insertion, and removal.
File summaries
| File | Description |
|---|---|
lib/conncache.c |
Removes bundle destination storage and updates hash operations. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We stored the "destination" string at each connection bundle, but it was never necessary to have it for operations. Remove the duplicated string from the bundle.