remove conn->given

[icing]

The connectdata member given is always the same as conn->origin->scheme. It never changes. Remove that member and always use the origin scheme instead.

[Copilot]

🟢 Approval recommended

The refactor cleanly removes conn->given and all repository references were updated consistently without introducing new call sites or leaving stale usages.

Pull request overview

This PR removes the internal connectdata->given scheme pointer and consistently uses conn->origin->scheme as the “initial / requested” scheme, aligning the implementation with the invariant described in the PR metadata.

Changes:

• Removed const struct Curl_scheme *given from struct connectdata.
• Updated connection scheme setup to use conn->origin->scheme directly.
• Replaced remaining conn->given references in reuse logging and HTTP/2 / HTTPSig authority handling with conn->origin->scheme.

File summaries

File	Description
lib/urldata.h	Removes the connectdata.given member from the connection struct.
lib/url.c	Adjusts scheme selection and reuse logging to reference conn->origin->scheme instead of conn->given.
lib/http2.c	Uses cf->conn->origin->scheme->defport for PUSH_PROMISE authority validation.
lib/http_httpsig.c	Uses conn->origin->scheme->defport when forming the HTTPSig authority.

Review details

• Files reviewed: 4/4 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.