Repository navigation
Conversation
hash.h functions had `void *key` as argument in several functions and those should be `const void *key` instead as they are not modified. Saves a ton of `CURL_UNCONST` use, often on string constants where they are definitely not wanted.
|
Analysis of PR #22886 at 11ee82c1: Test 440 failed, but it has been 1.6% flaky lately, so it's probably NOT a fault of the PR. Note that this test has failed in 12 different CI jobs (the link just goes to one of them). Generated by Testclutch |
bagder
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hash.h functions had
void *keyas argument in several functions and those should beconst void *keyinstead as they are not modified.Saves a ton of
CURL_UNCONSTuse, often on string constants where they are definitely not wanted.