Repository navigation
Conversation
bagder
approved these changes
Sep 9, 2026
There was a problem hiding this comment.
🟢 Approval recommended
The change is documentation-only and the remaining feedback is limited to minor wording/capitalization nits.
Pull request overview
Documents an IBM i (OS400) binding detail for curl_formadd_ccsid() so developers understand how multi-chunk “old-style” form data must be delimited when using repeated data/length option tuples (via CURLFORM_CONTENTTYPE).
Changes:
- Adds an explanation of the
CURLFORM_CONTENTTYPEdelimiter requirement when multiple data/length tuples are provided in a singlecurl_formadd_ccsid()call. - Adds/adjusts text noting that the legacy form API is deprecated in favor of the mime/MIME API.
- Minor wording/formatting adjustment in the vararg/overloading documentation section.
File summaries
| File | Description |
|---|---|
| projects/OS400/README.OS400 | Adds OS400-specific documentation for curl_formadd_ccsid() multi-chunk behavior and clarifies form-vs-mime API guidance. |
Review details
Suppressed comments (1)
projects/OS400/README.OS400:384
- Same capitalization issue as above: “mime API” should match the “MIME API” wording used elsewhere in OS400 docs (e.g., projects/OS400/rpg-examples/HTTPPOST).
curl_forms array. Please note the form API is deprecated and the mime API
should be used instead.
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
monnerat
force-pushed
the
doc-formadd
branch
from
September 9, 2026 11:57
2bb9661 to
89fc115
Compare
Contributor
Author
|
Thanks for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These details should inform os400 developers using libcurl about the extended use of
CURLFORM_CONTENTTYPE.