Repository navigation
Conversation
A .netrc file with only a comment and no newlined caused an NULL dereference Verify with test 2429 Reported-by: Max Dymond
There was a problem hiding this comment.
🟢 Approval recommended
The change directly prevents the reported NULL dereference and is covered by a focused new regression test.
Pull request overview
This PR fixes a crash in curl’s .netrc handling when the specified netrc file contains only a comment and does not end with a newline, and adds a regression test to cover that scenario.
Changes:
- Avoid calling the netrc parser when the loaded netrc buffer is empty (prevents NULL dereference).
- Add test 2429 to reproduce the “comment-only, no newline”
.netrccase. - Register the new test in the autotools test data list.
File summaries
| File | Description |
|---|---|
| lib/netrc.c | Adds an early return when the loaded netrc buffer is empty to avoid passing a NULL pointer into parsing. |
| tests/data/test2429 | New regression test that uses a comment-only netrc file with nonewline="yes" and verifies a normal HTTP request occurs. |
| tests/data/Makefile.am | Adds test2429 to the TESTCASES list so it’s included in the test suite. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A .netrc file with only a comment and no newline caused an NULL dereference
Verify with test 2429
Reported-by: Max Dymond