Repository navigation
Conversation
Added test 1791 to reproduce and verify fix. Reported-by: Max Dymond
There was a problem hiding this comment.
🟡 Changes recommended
The clone retains a source-owned pointer, and the regression test does not fail when duplication fails.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Optimizes duplication of zero-length copied POST data and adds regression coverage.
Changes:
- Avoids allocating when duplicating zero-byte POST fields.
- Registers test 1791 for the duplication scenario.
File summaries
| File | Description |
|---|---|
lib/easy.c |
Skips zero-length POST-field allocation. |
tests/libtest/lib1791.c |
Adds duplication regression test. |
tests/libtest/Makefile.inc |
Registers the test executable. |
tests/data/test1791 |
Defines the test case. |
tests/data/Makefile.am |
Registers test 1791. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bagder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test 1791 to reproduce and verify fix.
Reported-by: Max Dymond