Repository navigation
Conversation
When multi_ev is informed that a socket is about to be closed, it cleans up its entry for it (if it exists), but it did not remove it from any remembered "last pollset"s. When the OS reuses the file descriptor, this may lead to socket identity confusion on detecting changes of use. Remove the socket from any pollset that is registered at the socket entry of multi_ev when a socket is being "forgotten". Found-by: cmeister2
Contributor
Author
A wonderful new world we are making... |
bagder
approved these changes
Sep 10, 2026
There was a problem hiding this comment.
🟡 Changes recommended
The descriptor-reuse regression lacks automated test coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multi_ev is informed that a socket is about to be closed, it cleans up its entry for it (if it exists), but it did not remove it from any remembered "last pollset"s. When the OS reuses the file descriptor, this may lead to socket identity confusion on detecting changes of use.
Remove the socket from any pollset that is registered at the socket entry of multi_ev when a socket is being "forgotten".
Found-by: @cmeister2