Repository navigation
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
🟡 Changes recommended
The TLS session warning incorrectly states that session reuse bypasses the callback.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Clarifies risks and lifecycle behavior of the SSL context callback.
Changes:
- Documents invocation across DoH, redirects, and parallel connections.
- Adds connection and client-certificate reuse warnings.
File summaries
| File | Description |
|---|---|
docs/libcurl/opts/CURLOPT_SSL_CTX_FUNCTION.md |
Expands callback reuse and security caveats. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Basically this option is one big footgun Closes #22899
bagder
force-pushed
the
bagder/sslctx-clientcert
branch
from
September 10, 2026 11:50
ba5c51e to
15aa04d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically this option is one big footgun