Skip to content

lib: make private functions static and remove unused code - #22906

Closed
bagder wants to merge 16 commits into
masterfrom
bagder/private-funcs
Closed

bagder wants to merge 16 commits into
masterfrom
bagder/private-funcs

Conversation

@bagder

@bagder bagder commented Sep 10, 2026

Copy link
Copy Markdown
Member

No description provided.

@bagder bagder changed the title liub: make private functions static and remove unused code lib: make private functions static and remove unused code Sep 10, 2026
@github-actions github-actions Bot added the tests label Sep 10, 2026
@bagder
bagder requested a balanced review from Copilot September 10, 2026 21:08
@bagder
bagder marked this pull request as ready for review September 10, 2026 21:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A test-only definition retains an unconditional header declaration, and two documented prototypes are invalid or inaccurate.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Makes implementation-only helpers static, removes unused interfaces, and preserves unit-test access.

Changes:

  • Privatizes hash, list, splay-tree, string-set, and multi helpers.
  • Removes unused reader and splay APIs.
  • Updates unit tests and internal documentation.
File summaries
File Description
tests/unit/unit3211.c Uses private string-set helper.
tests/unit/unit1603.c Uses private hash helper.
tests/unit/unit1309.c Uses private splay helpers.
tests/unit/unit1300.c Uses private list helper.
lib/uint-hashset.h Removes string-set setter declaration.
lib/uint-hashset.c Privatizes string-set helpers.
lib/splay.h Removes private splay declarations.
lib/splay.c Privatizes and reorganizes splay operations.
lib/sendf.h Removes unused reader API declaration.
lib/sendf.c Removes unused reader implementation.
lib/multiif.h Removes running-transfer helper declaration.
lib/multi.c Makes running-transfer helper static.
lib/llist.h Removes private insertion declaration.
lib/llist.c Makes insertion helper static.
lib/hash.h Removes private hash declaration.
lib/hash.c Makes string hashing private.
docs/internals/SPLAY.md Updates splay helper names.
docs/internals/LLIST.md Updates linked-list helper names.
Review details
  • Files reviewed: 18/18 changed files
  • Comments generated: 3
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lib/uint-hashset.c
Comment thread docs/internals/LLIST.md
Comment thread docs/internals/SPLAY.md Outdated
@bagder bagder closed this in 2db7d4d Sep 11, 2026
@bagder
bagder deleted the bagder/private-funcs branch September 25, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants