Repository navigation
Conversation
bagder
marked this pull request as ready for review
September 10, 2026 21:08
There was a problem hiding this comment.
🟡 Changes recommended
A test-only definition retains an unconditional header declaration, and two documented prototypes are invalid or inaccurate.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Makes implementation-only helpers static, removes unused interfaces, and preserves unit-test access.
Changes:
- Privatizes hash, list, splay-tree, string-set, and multi helpers.
- Removes unused reader and splay APIs.
- Updates unit tests and internal documentation.
File summaries
| File | Description |
|---|---|
tests/unit/unit3211.c |
Uses private string-set helper. |
tests/unit/unit1603.c |
Uses private hash helper. |
tests/unit/unit1309.c |
Uses private splay helpers. |
tests/unit/unit1300.c |
Uses private list helper. |
lib/uint-hashset.h |
Removes string-set setter declaration. |
lib/uint-hashset.c |
Privatizes string-set helpers. |
lib/splay.h |
Removes private splay declarations. |
lib/splay.c |
Privatizes and reorganizes splay operations. |
lib/sendf.h |
Removes unused reader API declaration. |
lib/sendf.c |
Removes unused reader implementation. |
lib/multiif.h |
Removes running-transfer helper declaration. |
lib/multi.c |
Makes running-transfer helper static. |
lib/llist.h |
Removes private insertion declaration. |
lib/llist.c |
Makes insertion helper static. |
lib/hash.h |
Removes private hash declaration. |
lib/hash.c |
Makes string hashing private. |
docs/internals/SPLAY.md |
Updates splay helper names. |
docs/internals/LLIST.md |
Updates linked-list helper names. |
Review details
- Files reviewed: 18/18 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.