Repository navigation
dynhds: grow header array geometrically - #22910
Closed
MegaManSec wants to merge 1 commit into
Closed
MegaManSec wants to merge 1 commit into
MegaManSec wants to merge 1 commit into
Conversation
MegaManSec
changed the title
Curl_dynhds_add grew its pointer array by a fixed 16 slots per resize, copying every existing pointer each time and doing O(n^2) aggregate work across n inserts. Grow geometrically instead for amortized O(1) appends.
MegaManSec
force-pushed
the
worktree-agent-aa310a8b8c867e28d
branch
from
September 11, 2026 06:44
343d8d3 to
d24b8d5
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curl_dynhds_add() grew its pointer array by a fixed 16 slots per resize. Appending N headers therefore repeatedly copied the existing pointers, resulting in O(N²) aggregate work.
Grow the array geometrically instead. Appends are now amortized O(1), while the existing max_entries cap continues to limit the allocation when configured.