Repository navigation
Conversation
Clarify that this goes the same for the name as for the content.
There was a problem hiding this comment.
🟢 Approval recommended
Only a minor wording nit was identified; no blocking issues remain.
Pull request overview
This pull request clarifies CURLFORM_NAMELENGTH behavior when passed zero.
Changes:
- Documents
strlen()-based name-length detection. - Clarifies empty-name handling.
File summaries
| File | Description |
|---|---|
docs/libcurl/curl_formadd.md |
Adds documentation for automatic name-length detection and zero-length names. |
Review details
Suppressed comments (1)
docs/libcurl/curl_formadd.md:123
- "Zero byte name" is ambiguous/inaccurate here: it normally describes a name containing a NUL byte, which the preceding option docs prohibit and the implementation rejects. A
strlen()result of zero means an empty, zero-length name; please use that wording so this does not contradict the documented restriction.
figure out the size. If you really want to send a zero byte name then you must
make sure strlen() on the name pointer returns zero.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that this goes the same for the name as for the content.