Repository navigation
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The test uses an incomplete feature guard and does not reliably distinguish iterative cleanup from the previous recursive behavior.
Pull request overview
Reworks MIME cleanup to avoid recursive destruction of nested multipart structures and adds a unit test.
Changes:
- Implements iterative MIME tree cleanup.
- Adds and registers a nested-MIME unit test.
- Registers test 3595 in the test suite.
File summaries
| File | Description |
|---|---|
lib/mime.c |
Implements non-recursive MIME cleanup. |
tests/unit/unit3595.c |
Adds nested multipart cleanup coverage. |
tests/unit/Makefile.inc |
Registers the unit source. |
tests/data/test3595 |
Defines the test case. |
tests/data/Makefile.am |
Registers test 3595. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Analysis of PR #22927 at 19455974: Test 3595 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 58 different CI jobs (the link just goes to one of them). Generated by Testclutch |
This comment was marked as resolved.
This comment was marked as resolved.
bagder
force-pushed
the
bagder/mimefree-recursive
branch
from
September 13, 2026 08:41
1945597 to
e69afdb
Compare
Verify with test 3595: deeply nested curl_mime_free()
bagder
force-pushed
the
bagder/mimefree-recursive
branch
from
September 13, 2026 13:49
361fb69 to
17a5d9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.