Repository navigation
Conversation
It only uses public libcurl functions. Closes #22928
bagder
force-pushed
the
bagder/not-unit
branch
from
September 13, 2026 13:50
6c1220e to
d9c50e2
Compare
bagder
marked this pull request as ready for review
September 13, 2026 14:30
There was a problem hiding this comment.
🔵 Needs a closer look
Add curl_easy_unescape to the test keywords so filtered runs select this regression test.
Pull request overview
Moves test 1605 from the unit-test suite to libtest to validate public libcurl APIs.
Changes:
- Removes and adds the relevant test registrations.
- Renames the test entry point.
- Updates metadata to invoke
lib1605.
File summaries
| File | Description |
|---|---|
tests/unit/Makefile.inc |
Removes unit-test registration. |
tests/libtest/Makefile.inc |
Adds libtest registration. |
tests/libtest/lib1605.c |
Renames the test entry point. |
tests/data/test1605 |
Switches execution to the libtest tool. |
Review details
Suppressed comments (1)
tests/data/test1605:5
- This test exercises both
curl_easy_escapeandcurl_easy_unescape(the latter atlib1605.c:58), but the keyword list only advertisescurl_easy_escape. Becauseruntests.plselects tests by these keywords, a run filtered with-k curl_easy_unescapewill skip this regression test; add the missing keyword.
curl_easy_escape
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It only uses public libcurl functions.