Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The loop-limit check can discard the final chunk and incorrectly convert read errors into success.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a ten-iteration read-loop limit to Curl_pp_readresp to prevent excessive looping while reading responses.
Changes:
- Adds a bounded response-read loop.
- Applies the limit during response processing.
File summaries
| File | Summary |
|---|---|
lib/pingpong.c |
Adds the response-read loop counter. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
To make sure it cannot get stuck in this function. Reported-by: Joshua Rogers
a90dce0 to
a0d4bd6
Compare
|
Analysis of PR #22932 at a0d4bd60: Test 3232 failed, but it has been 94.4% flaky lately, so it's probably NOT a fault of the PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Note that this CI job has had a number of other flaky tests recently (3, to be specific) so it may be that this failure is rather a systemic issue with this job and not with this specific PR. Generated by Testclutch |
There was a problem hiding this comment.
🟡 Changes recommended
The loop guard can skip the tenth read and return before the response is fully processed.
Get a fresh assessment by requesting another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
ok, post increment Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
To make sure it cannot get stuck in this function.
Reported-by: Joshua Rogers