Repository navigation
Conversation
The multi's "run dirty" loop ignored transfers that are not in processing state, e.g. pending transfers. That led to timeouts not being acted upon for those transfers. Fixed by moving a "dirty" pending transfer to the connect state and processing it. Added test_02_37 for verification.
bagder
approved these changes
Sep 14, 2026
There was a problem hiding this comment.
🟢 Approval recommended
The focused change has regression coverage and no unresolved review issues.
Pull request overview
Fixes timeouts for pending transfers in the multi interface and adds regression coverage.
Changes:
- Processes dirty pending transfers through the connect state.
- Adds a debug connection-limit control.
- Adds HTTP test coverage and documentation.
File summaries
| File | Description |
|---|---|
tests/http/test_02_download.py |
Tests pending-transfer timeout behavior. |
lib/multi.c |
Handles dirty pending transfers and debug connection limits. |
docs/libcurl/libcurl-env-dbg.md |
Documents the debug environment variable. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The multi's "run dirty" loop ignored transfers that are not in processing state, e.g. pending transfers. That led to timeouts not being acted upon for those transfers.
Fixed by moving a "dirty" pending transfer to the connect state and processing it.
Added test_02_37 for verification.