Repository navigation
Conversation
bagder
marked this pull request as ready for review
September 14, 2026 13:54
bagder
force-pushed
the
bagder/transfer-encoding
branch
from
September 14, 2026 14:24
e73aebe to
8fa85c0
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Content-Length handling remains order-dependent when it precedes Transfer-Encoding.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Ensures raw, non-chunked Transfer-Encoding responses use connection closure rather than Content-Length for framing.
Changes:
- Ignores Content-Length after non-chunked Transfer-Encoding.
- Expands test 319 with an incorrect Content-Length.
File summaries
| File | Description |
|---|---|
lib/http.c |
Updates response framing and Content-Length handling. |
tests/data/test319 |
Tests close-delimited raw transfer data. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bagder
force-pushed
the
bagder/transfer-encoding
branch
2 times, most recently
from
September 15, 2026 15:38
8fa85c0 to
671d590
Compare
There is no other way to know when the transfer ends when there is a transfer encoding set but not chunked - even if transfere-encoding is disabled. Tweak test 319 to verify this (by setting a wrong Content-Length). Add test 2918 to make sure it works the same also when the Content-Length and Transfer-Encoding headers arrive in the other order
bagder
force-pushed
the
bagder/transfer-encoding
branch
from
September 18, 2026 06:09
671d590 to
170b8f3
Compare
Contributor
|
test1494 hangs now. It is a response with So, fix/scrap that test case? |
Member
Author
|
I fixed the test case to correctly close the connection after the response |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no other way to know when the transfer ends. Tweak test 319 to verify this (by setting a wrong Content-Length).