Repository navigation
tool_help: guard category[2] access when category is bare "-" - #22957
Closed
MegaManSec wants to merge 1 commit into
Closed
MegaManSec wants to merge 1 commit into
MegaManSec wants to merge 1 commit into
Conversation
When category is "-" (length 1), category[1] is already the null terminator. The else-if on line 272 then reads category[2] without first confirming category[1] is non-null, producing a one-byte heap-buffer-overflow that ASan flags. Add the category[1] guard so the short-option path is only taken for exactly two-character inputs like "-x".
MegaManSec
force-pushed
the
fix/tool-help-oob-read-bare-dash
branch
from
September 15, 2026 15:06
aa8d6e1 to
9fbb9ac
Compare
bagder
approved these changes
Sep 15, 2026
Contributor
Author
|
bounty? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR patches a critical vulnerability, which happens when using
curl --help -.When category is "-" (length 1), category[1] is already the null terminator. The else-if on line 272 then reads category[2] without first confirming category[1] is non-null, producing a one-byte heap-buffer-overflow that ASan flags. Add the category[1] guard so the short-option path is only taken for exactly two-character inputs like "-x".