cookie: accept slightly longer lines in cookie jars

[bagder]

No description provided.

[testclutch]

Analysis of PR #22964 at a7cf5198:

Test ../../tests/http/test_21_resolve.py::TestResolve::test_21_09_dnsd_a_delay[DoH] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them).

Test ../../tests/http/test_21_resolve.py::TestResolve::test_21_10_dnsd_aaaa_delay[DoH] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them).

Test ../../tests/http/test_21_resolve.py::TestResolve::test_21_13_dnsd_nxdomain_cached[DoH] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them).

Generated by Testclutch

[Copilot]

🟡 Changes recommended

The line-limit divergence needs resolution and boundary regression coverage, with a minor comment correction also requested.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adjusts cookie-jar loading to accept slightly longer lines without aborting file reads.

Changes:

• Increases the dynamic cookie-jar buffer by 48 bytes.
• Adds rationale for the increased limit.

File summaries

File	Changes and findings
lib/cookie.c	Expands the cookie-jar line buffer. Moderate (2 votes): document or enforce the differing Netscape line limit. Nit (3 votes): add boundary regression coverage. Nit (1 vote): correct the comment wording.

Review details

Suppressed comments (1)

lib/cookie.c:1185

• The comment should say “slightly longer lines” (or “a few longer lines”); “a little longer lines” is grammatically incorrect.

    /* accept a little longer lines so that a full cookie fits and does not
       abort the file read */

• Files reviewed: 1/1 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.