Repository navigation
Conversation
Retain the parsed CURLU on accepted pushed transfers so retries and relative redirects have valid URL state. Add regression coverage for relative redirects on pushed streams. Closes #22970
There was a problem hiding this comment.
🟢 Approval recommended
URL ownership and cleanup are correct, and the regression test exercises the affected redirect path.
Pull request overview
Initializes URL state for HTTP/2 pushed transfers, enabling relative redirect resolution and retries.
Changes:
- Retains the parsed
CURLUon pushed handles. - Adds regression coverage for relative push redirects.
- Reports resolved redirect URLs from the test client.
File summaries
| File | Description |
|---|---|
lib/http2.c |
Retains parsed push URL state. |
tests/libtest/cli_h2_serverpush.c |
Reports pushed-transfer redirect URLs. |
tests/http/test_09_push.py |
Tests relative redirect resolution. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
icing
reviewed
Sep 16, 2026
icing
self-requested a review
September 16, 2026 14:25
icing
approved these changes
Sep 16, 2026
This was referenced Sep 27, 2026
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retain the parsed CURLU on accepted pushed transfers so retries and relative redirects have valid URL state.
Add regression coverage for relative redirects on pushed streams.