Repository navigation
Conversation
icing
commented
Sep 18, 2026
icing
commented
Contributor
- u8_strset: iterator over all entries using a uint16_t index
- u32_ptrset: limit max size to 31 bits, managing INT32_MAX entries
- u8_strset: iterator over all entries using a uint16_t index - u32_ptrset: limit max size to 31 bits, managing INT32_MAX entries
There was a problem hiding this comment.
🟡 Changes recommended
The new growth boundary permits allocation-size overflow on 32-bit targets, and the documented maximum is inconsistent with the implementation.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates set boundary handling for maximum capacities.
Changes:
- Uses a 16-bit iterator when rehashing
u8_strset. - Limits
u32_ptrsetgrowth to 31 slot bits. - Updates the documented pointer capacity.
File summaries
| File | Description |
|---|---|
lib/u8_strset.c |
Widens the rehash iterator. |
lib/u32_ptrset.c |
Adds the 31-bit growth limit. |
lib/u32_ptrset.h |
Revises capacity documentation. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bagder
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.