Repository navigation
formdata: reject a negative content length in curl_formadd - #22996
Closed
MegaManSec wants to merge 1 commit into
Closed
MegaManSec wants to merge 1 commit into
MegaManSec wants to merge 1 commit into
Conversation
CURLFORM_CONTENTSLENGTH and CURLFORM_CONTENTLEN accepted a negative length, which reached forminfo_copyfield() and the mime conversion as a near-SIZE_MAX size_t. Return CURL_FORMADD_INCOMPLETE instead.
Contributor
Author
|
Note: this is a hardening, obviously, and caller misuse. |
bagder
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curl_formadd()accepted a negativeCURLFORM_CONTENTSLENGTH/CURLFORM_CONTENTLEN. The value reachesforminfo_copyfield(&form->value, (size_t)form->contentslength)and the mimeconversion as a near-
SIZE_MAXlength. Reject it withCURL_FORMADD_INCOMPLETE.