Repository navigation
tool_getparam: do not print the value of a redacted argument - #22997
Closed
MegaManSec wants to merge 1 commit into
Closed
MegaManSec wants to merge 1 commit into
MegaManSec wants to merge 1 commit into
Conversation
The Unicode warning printed the full argument, including for ARG_CLEAR options such as --user and --oauth2-bearer whose values cleanarg() wipes from argv to keep them out of the process list. Print the option name instead for those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "starts with a Unicode character" warning printed the full argument,
including for
ARG_CLEARoptions such as--user,--passand--oauth2-bearer.cleanarg()wipes those values from argv to keep them outof the process list, so writing them to stderr is inconsistent. Print the
option name instead for those; other options are unchanged.
Applies to values from a config file too.