Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in README #2300

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@brunograsselli
Copy link
Contributor

commented Feb 9, 2018

I think there is a typo in the README.

README.md Outdated
@@ -38,7 +38,7 @@ downloads.

## Git

To download the very latest source off the Git server do this:
To download the very latest source of the Git server do this:

This comment has been minimized.

Copy link
@bagder

bagder Feb 9, 2018

Member

This changes the meaning of the sentence. The latest source of the server would imply you get a server source code downloaded. Downloading it off the server would imply you get it from the server.

Maybe use from instead of off ?

Fix typo in README
I think there is a typo in the README.

@brunograsselli brunograsselli force-pushed the brunograsselli:patch-1 branch from 5995b78 to 34ab1fd Feb 9, 2018

@brunograsselli

This comment has been minimized.

Copy link
Contributor Author

commented Feb 9, 2018

@bagder I see your point. I changed to use from instead of of.
Feel free to reject the PR in case off makes more sense than from.

@bagder bagder closed this in b9e3233 Feb 12, 2018

@bagder

This comment has been minimized.

Copy link
Member

commented Feb 12, 2018

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators May 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.