Repository navigation
Conversation
Windows recognizes the 8-bit *superscript* digits 1, 2, and 3 as digits and treats them as valid parts of COM# and LPT# device names. Both when provided as ISO8859-1 as well as UTF-8. Reported-by: Joshua Rogers
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Three test expectations incorrectly include a leading underscore and will fail against the sanitizer’s existing extension behavior.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Extends Windows filename sanitization to recognize superscript digits in reserved COM/LPT device names.
Changes:
- Adds reserved-prefix detection for ISO-8859-1 and UTF-8 superscript digits.
- Expands sanitizer test coverage.
| File | Description |
|---|---|
src/tool_doswin.c |
Adds centralized reserved device-prefix detection. |
tests/tunit/tool1604.c |
Adds COM/LPT digit and superscript cases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows recognizes the 8-bit superscript digits 1, 2, and 3 as digits and treats them as valid parts of COM# and LPT# device names. Both when provided as ISO8859-1 as well as UTF-8.
Reported-by: Joshua Rogers