Repository navigation
Conversation
Restrict Negotiate/NTML to only "allowed" origins, irregardless of where credentials are sourced from.
bagder
approved these changes
Sep 21, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new security boundary lacks cross-origin regression coverage for both authentication methods.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Restricts origin Negotiate and NTLM authentication to explicitly allowed hosts, preventing credential forwarding across redirects.
Changes:
- Guards Negotiate and NTLM header generation by origin authorization.
- Marks blocked authentication attempts complete.
| File | Description |
|---|---|
lib/http.c |
Enforces origin checks for Negotiate and NTLM authentication. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+694
to
+695
| (!proxy && !Curl_checkheaders(data, STRCONST("Authorization")) && | ||
| Curl_auth_allowed_to_host(data))) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restrict Negotiate/NTML to only "allowed" origins, irregardless of where credentials are sourced from.