Repository navigation
Conversation
The three first letters of the weekdays are never actually used in the weekday array so drop them. Also make the array local.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The comparison length rejects valid weekday tokens followed by delimiters.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Moves weekday suffix data into checkday() and removes redundant prefixes.
Changes:
- Replaces full weekday names with suffixes.
- Makes the lookup array function-local.
| File | Description |
|---|---|
lib/parsedate.c |
Refactors full weekday validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three first letters of the weekdays are never actually used in the weekday array so drop them. Also make the array local.