getinfo: make sure CURLINFO_EFFECTIVE_URL does not contain creds

[bagder]

Reported-by: Joshua Rogers

[Copilot]

Copilot review overview

🟡 Changes recommended

The implementation corrupts CURLINFO_REDIRECT_URL state and regresses valid unsupported-scheme and path-as-is URLs.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2 · 1

Open (3)

• Preserve URL scheme and path-as-is flags when reparsing · New
• Store sanitized effective URL separately from redirect URL · New
• Rename test to reflect credential-redaction scenario · New

What changed in this PR

Prevents credentials from appearing in CURLINFO_EFFECTIVE_URL.

Changes:

• Sanitizes effective URLs through the URL API.
• Adds netrc redirect coverage.
• Removes an unsupported-scheme test case.

File	Description
lib/​getinfo.c	Sanitizes effective URLs.
lib/​urldata.h	Updates redirect storage documentation.
tests/​data/​test1876	Adds netrc credential regression coverage.
tests/​data/​test424	Removes unsupported-scheme coverage.
tests/​data/​Makefile.am	Registers test 1876.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[testclutch]

Analysis of PR #23016 at d6abaf89:

Test ../../tests/http/test_21_resolve.py::TestResolve::test_21_07_dnsd_a[DoH] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them).

Test ../../tests/http/test_21_resolve.py::TestResolve::test_21_08_dnsd_aaaa[DoH] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them).

Test ../../tests/http/test_21_resolve.py::TestResolve::test_21_09_dnsd_a_delay[DoH] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them).

Test ../../tests/http/test_21_resolve.py::TestResolve::test_21_10_dnsd_aaaa_delay[DoH] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them).

Test ../../tests/http/test_21_resolve.py::TestResolve::test_21_13_dnsd_nxdomain_cached[DoH] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them).

Generated by Testclutch